Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adaptive formatting typo in explore dropdowns #19312

Merged
merged 1 commit into from
Apr 6, 2022
Merged

fix: adaptive formatting typo in explore dropdowns #19312

merged 1 commit into from
Apr 6, 2022
+22 −22

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

In time-series type charts in customize section we have fields that are related to numbers - y axis format, time format, tooltip time format (and maybe more?). The default setting is "adaptive formatting" and it's spelled wrong.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 22, 2022 •
edited
Loading

Codecov Report

Merging #19312 (0549a6d) into master (7ca10fb) will decrease coverage by 0.18%.
The diff coverage is n/a.

❗ Current head 0549a6d differs from pull request most recent head 0acd4ad. Consider uploading reports for the commit 0acd4ad to get more accurate results

@@            Coverage Diff             @@
##           master   #19312      +/-   ##
==========================================
- Coverage   66.65%   66.46%   -0.19%     
==========================================
  Files        1672     1672              
  Lines       64611    64611              
  Branches     6505     6505              
==========================================
- Hits        43066    42946     -120     
- Misses      19862    19982     +120     
  Partials     1683     1683
Flag Coverage Δ
hive ?
javascript 51.33% <ø> (ø)
mysql 81.66% <ø> (ø)
postgres 81.70% <ø> (ø)
presto ?
python 81.75% <ø> (-0.38%) ⬇️
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-ui-chart-controls/src/utils/D3Formatting.ts 100.00% <ø> (ø)
superset-frontend/src/explore/controls.jsx 31.57% <ø> (ø)
superset-frontend/src/views/components/Menu.tsx 60.00% <ø> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.00% <0.00%> (-15.77%) ⬇️
superset/db_engine_specs/presto.py 83.68% <0.00%> (-5.44%) ⬇️
superset/db_engine_specs/sqlite.py 91.89% <0.00%> (-5.41%) ⬇️
superset/utils/celery.py 86.20% <0.00%> (-3.45%) ⬇️
superset/connectors/sqla/utils.py 88.33% <0.00%> (-3.34%) ⬇️
superset/result_set.py 96.77% <0.00%> (-1.62%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ca10fb...0acd4ad. Read the comment docs.

rusackas
rusackas approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit 0363e55 into apache:master Apr 6, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@diegomedina248 @philipher29
fix: adaptive formatting typo in explore dropdowns (apache#19312)
0702d64
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 and removed 🚢 2.0.1 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels Preset-Patch size/M 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diegomedina248 @rusackas @mistercrunch